[uClibc]system.c patch?

Erik Andersen andersen at codepoet.org
Mon Jul 29 18:39:28 UTC 2002


On Mon Jul 29, 2002 at 04:57:22PM +0200, Tobias Anderberg wrote:
> diff -u -w -r1.7 system.c
> --- system.c    21 Feb 2002 18:11:44 -0000      1.7
> +++ system.c    29 Jul 2002 14:52:03 -0000
> @@ -6,7 +6,7 @@
> 
>  /* uClinux-2.0 has vfork, but Linux 2.0 doesn't */
>  #include <sys/syscall.h>
> -#if ! defined __NR_vfork && defined __UCLIBC_HAS_MMU__
> +#if ! defined __NR_vfork || defined __UCLIBC_HAS_MMU__
>  #define vfork fork
>  #endif
> 
> I.e. doesn't it make more sense to use fork() if we don't have
> vfork() _or_ we have a mmu? I mean, if an mmu is available, fork is
> preferred over vfork, even if it exists, right?
> 
> What happens if we don't have vfork() or an mmu? Ok, it is slightly
> unlikley, but still! ;-)

Hmm.  Perhaps it would be better then to use:
    #if ! defined __NR_vfork && ! defined __UCLIBC_HAS_MMU__ 

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--



More information about the uClibc mailing list