[git commit branch/0.9.33] fchmodat: fix handling of flags

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Tue Apr 3 17:38:55 UTC 2012


commit: http://git.uclibc.org/uClibc/commit/?id=6dc563a7f56c8e1f97d39aa489fb68a28a4c7bbf
branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/0.9.33

The Linux syscall takes 3 args, not 4.  We have to process flags in
userspace ourselves.

Signed-off-by: Mike Frysinger <vapier at gentoo.org>
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
---
 libc/sysdeps/linux/common/fchmodat.c |   23 ++++++++++++++++++++++-
 1 files changed, 22 insertions(+), 1 deletions(-)

diff --git a/libc/sysdeps/linux/common/fchmodat.c b/libc/sysdeps/linux/common/fchmodat.c
index 7d4dd4e..8224a52 100644
--- a/libc/sysdeps/linux/common/fchmodat.c
+++ b/libc/sysdeps/linux/common/fchmodat.c
@@ -2,15 +2,36 @@
  * fchmodat() for uClibc
  *
  * Copyright (C) 2009 Analog Devices Inc.
+ * Copyright (C) 2012 Mike Frysinger
  *
  * Licensed under the LGPL v2.1, see the file COPYING.LIB in this tarball.
  */
 
+#include <fcntl.h>
 #include <sys/syscall.h>
 #include <sys/stat.h>
 
 #ifdef __NR_fchmodat
-_syscall4(int, fchmodat, int, fd, const char *, file, mode_t, mode, int, flag)
+/*
+ * The kernel takes 3 args, but userland takes 4.
+ * We have to process all the flags ourselves.
+ */
+int fchmodat(int fd, const char *file, mode_t mode, int flag)
+{
+	/* We only support one flag atm ... */
+	if (flag & ~AT_SYMLINK_NOFOLLOW) {
+		__set_errno(EINVAL);
+		return -1;
+	}
+
+	/* ... but Linux doesn't support perms on symlinks. */
+	if (flag & AT_SYMLINK_NOFOLLOW) {
+		__set_errno(ENOTSUP);
+		return -1;
+	}
+
+	return INLINE_SYSCALL(fchmodat, 3, fd, file, mode);
+}
 #else
 /* should add emulation with fchmod() and /proc/self/fd/ ... */
 #endif


More information about the uClibc-cvs mailing list