svn commit: trunk/uClibc/include

[vda at uclibc.org]

Author: vda
Date: 2008-12-13 07:21:07 -0800 (Sat, 13 Dec 2008)
New Revision: 24407

Log:
features.h: add TODO (changing __OPTIMIZE_SIZE__ is a wrong thing to do)



Modified:
   trunk/uClibc/include/features.h


Changeset:
Modified: trunk/uClibc/include/features.h
===================================================================
--- trunk/uClibc/include/features.h	2008-12-13 15:02:30 UTC (rev 24406)
+++ trunk/uClibc/include/features.h	2008-12-13 15:21:07 UTC (rev 24407)
@@ -37,7 +37,13 @@
 #include <bits/uClibc_arch_features.h>
 
 /* For uClibc, always optimize for size -- this should disable
- * a lot of expensive inlining... */
+ * a lot of expensive inlining...
+ * TODO: this is wrong! __OPTIMIZE_SIZE__ is an indicator of
+ * gcc -Os compile. We should not mess with compiler inlines.
+ * We should instead disable __USE_EXTERN_INLINES unconditionally,
+ * or maybe actually audit and test uclibc to work correctly
+ * with __USE_EXTERN_INLINES on.
+ */
 #define __OPTIMIZE_SIZE__   1
 
 /* These are defined by the user (or the compiler)