[git commit] buildsys: fixup sigaction handling

Carmelo AMOROSO carmelo.amoroso at st.com
Mon Jan 30 15:15:42 UTC 2012


On 30/01/2012 16.00, Bernhard Reutner-Fischer wrote:
> On Jan 30, 2012 3:15 PM, "Carmelo AMOROSO" <carmelo.amoroso at st.com> wrote:
>>
> 
>>> diff --git a/libpthread/nptl/sysdeps/pthread/sigaction.c
> b/libpthread/nptl/sysdeps/pthread/pt-sigaction.c
>>> similarity index 84%
>>> rename from libpthread/nptl/sysdeps/pthread/sigaction.c
>>> rename to libpthread/nptl/sysdeps/pthread/pt-sigaction.c
>>
>> I wouldn't have renamed to pt-sigaction, as it seems to me that the pt-
>> prefix is used for implementation within libpthread.
> 
> Well, the impl (wrapper in this case) does live in libpthread, so I think
> it is consistent, isn't it?
> 

we were not following this for all impl that are filtered-out from libc
folders in order to use an impl pthread-aware from libpthread folder,
but it seems that some tidy-up I've not deeply looked at are following
this approach, so indeed it is consistent.

>> what about removing the __sigaction symbol, and use a plain sigation ?
>> further libc_hidden_proto could be removed as well as we are now
>> including signal.h
> 
> Further cleanups are of course welcome :)
> 

ok ;-)

thanks,
carmelo

> 
> 
> 
> _______________________________________________
> uClibc-cvs mailing list
> uClibc-cvs at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc-cvs



More information about the uClibc-cvs mailing list