[git commit nptl] utent.c: fix a few bugs, and shrink a bit
Mike Frysinger
vapier at gentoo.org
Fri Sep 18 23:37:04 UTC 2009
On Friday 18 September 2009 15:04:56 Bernhard Reutner-Fischer wrote:
> On Fri, Sep 18, 2009 at 04:07:31PM +0200, Denys Vlasenko wrote:
> >commit:
> > http://git.uclibc.org/uClibc/commit/?id=2b5155d358188649cc7a6653b5968b514
> >fbfe9cf branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/nptl
> >
> >bug #1:
> > static_fd = -1;
> > close(static_fd);
> >DOH!
> >
> >- return;
> >- }
> >+ // thus far, {G,S}ETFD only has this single flag,
> >+ // and setting it never fails.
> >+ //int ret = fcntl(static_fd, F_GETFD, 0);
> >+ //if (ret >= 0) {
> >+ // ret = fcntl(static_fd, F_SETFD, ret | FD_CLOEXEC);
> >+ //}
> >+ //if (ret < 0) {
> >+ // static_fd = -1;
> >+ //}
> >+ return;
>
> please, PLEASE use C89 compatible comments or #if 00 them out
> so they are easily grep'able.
> Using C99 comments is _not_ acceptable, it breaks real bootstraps with
> some compilers out there in the wild!
and they're just plain ugly. how about a git commit hook that rejects //
comments in .c code ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc-cvs/attachments/20090918/a82d7fe1/attachment.pgp>
More information about the uClibc-cvs
mailing list