[git commit nptl] lckpwdf: remove a wrong comment and one write-only variable

Denys Vlasenko vda.linux at googlemail.com
Fri Sep 18 14:07:31 UTC 2009


commit: http://git.uclibc.org/uClibc/commit/?id=d56307e14a572e5b7febaf2d20ba71e72d421d2e
branch: http://git.uclibc.org/uClibc/commit/?id=refs/heads/nptl

no code changes (verified with objdump)

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
Signed-off-by: Austin Foxley <austinf at cetoncorp.com>
---
 libc/pwd_grp/lckpwdf.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/libc/pwd_grp/lckpwdf.c b/libc/pwd_grp/lckpwdf.c
index 68c46e0..d9776ed 100644
--- a/libc/pwd_grp/lckpwdf.c
+++ b/libc/pwd_grp/lckpwdf.c
@@ -51,7 +51,6 @@ lckpwdf (void)
   struct sigaction new_act;		/* New signal action.  */
   struct flock fl;			/* Information struct for locking.  */
   int result;
-  int rv = -1;
 
   if (lock_fd != -1)
     /* Still locked by own process.  */
@@ -65,7 +64,6 @@ lckpwdf (void)
 #endif
   lock_fd = open (_PATH_PASSWD, O_WRONLY | O_CLOEXEC);
   if (lock_fd == -1) {
-    /* Cannot create lock file.  */
     goto DONE;
   }
   /* Make sure file gets correctly closed when process finished.  */
@@ -115,13 +113,11 @@ lckpwdf (void)
   if (result < 0) {
     close(lock_fd);
     lock_fd = -1;
-    goto DONE;
   }
-  rv = 0;
 
 DONE:
   __UCLIBC_MUTEX_UNLOCK(mylock);
-  return 0;
+  return 0; /* TODO: return result? */
 }
 
 
-- 
1.6.3.3



More information about the uClibc-cvs mailing list