[git commit master] ldso/: tls support for dynamic linker

[Mike Frysinger]

On Thursday 15 October 2009 16:36:12 Austin Foxley wrote:
> On 10/15/2009 01:26 PM, Mike Frysinger wrote:
> > i dont know if you're merging this from somewhere or writing it yourself,
> > but this is full of style problems.  whoever is the source needs to fix
> > their behavior.  trailing whitespace, missing whitespace inline "if(",
> > "char*", etc...
> 
> I'm just merging code that has been in the nptl branch for quite a while.
>  I'm willing to work on any fixes you think are necessary though.

well if this merge is any indication, the branch is full of crap.  highlights 
of crazy basic things that are wrong:
if(foo) /* missing space after "if" */

if (foo) /* the brace is supposed to be cuddled */
{

func (args); /* no space before args */

trailing whitespace

using spaces for indentation when it should be tabs -- even worse when it's in 
the middle of a function that otherwise is tabs

adding code to the middle of a function: not indented at all, not indented 
enough, or indented too much

> > ignoring the blatant style problems, it seems to be mucking with hashing
> > logic that it doesnt understand all that well.  it reverts code for no
> > apparent reason screwing the FDPIC port pretty badly.
> 
> That's unfortunate. Can you highlight which hunks are necessary for the
>  FDPIC port? I'm not familiar with what is needed there.

look at the diff and search for __FDPIC__.  it should be obvious where changes 
were blindly reverted.  i'm fixing it now so dont worry about having to fix 
it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/uclibc-cvs/attachments/20091015/2a3e8a75/attachment.pgp>