[git commit nptl] undef INTERNAL_SYSCALL_NCS before redefining to quash build warnings.

[Khem Raj]

On (13/08/09 14:32), Mike Frysinger wrote:
> On Thursday 13 August 2009 12:03:19 Khem Raj wrote:
> > On (13/08/09 07:11), Mike Frysinger wrote:
> > > On Saturday 01 August 2009 05:26:11 Khem Raj wrote:
> > > > --- a/libpthread/nptl/sysdeps/unix/sysv/linux/arm/sysdep.h
> > > > +++ b/libpthread/nptl/sysdeps/unix/sysv/linux/arm/sysdep.h
> > > > @@ -305,11 +305,13 @@ __local_syscall_error:						\
> > > >  #define ASM_ARGS_7	ASM_ARGS_6, "r" (_v3)
> > > >
> > > >  #if defined(__ARM_EABI__)
> > > > +#undef INTERNAL_SYSCALL_NCS
> > > >  #define INTERNAL_SYSCALL_NCS(number, err, nr, args...)		\
> > > >  	INTERNAL_SYSCALL_RAW(number, err, nr, args)
> > > >  #else
> > > >  /* We can't implement non-constant syscalls directly since the syscall
> > > >     number is normally encoded in the instruction.  So use SYS_syscall.
> > > >  +#undef INTERNAL_SYSCALL_NCS
> > > >  #define INTERNAL_SYSCALL_NCS(number, err, nr, args...)		\
> > > >  	INTERNAL_SYSCALL_NCS_##nr (number, err, args)
> > >
> > > what build warnings exactly are you seeing ?  i dropped these #undef on
> > > purpose because nowhere else should these things be defined ...
> >
> > on nptl branch libpthread/nptl/sysdeps/unix/sysv/linux/arm/sysdep.h
> > defines them too.
> 
> so how exactly do you make sure the right one is used ?  if both go undefining 
> the other, seems like you'll randomly end up with different versions at 
> runtime based solely on implicit includes.  while glibc has no problem forcing 
> people into that kind of asinine behavior, i'd like to avoid it.

If we can get the functionality of nptl sysdep.h into common one then it
would not be needed. 

> -mike



> _______________________________________________
> uClibc-cvs mailing list
> uClibc-cvs at uclibc.org
> http://lists.busybox.net/mailman/listinfo/uclibc-cvs