svn commit: trunk/uClibc: libc/misc/syslog libc/pwd_grp libc/signa etc...
vda at uclibc.org
vda at uclibc.org
Mon Dec 1 20:29:53 UTC 2008
Author: vda
Date: 2008-12-01 12:29:52 -0800 (Mon, 01 Dec 2008)
New Revision: 24223
Log:
on Bernd's request, remove commented-out code snippets
Modified:
trunk/uClibc/libc/misc/syslog/syslog.c
trunk/uClibc/libc/pwd_grp/lckpwdf.c
trunk/uClibc/libc/signal/sigignore.c
trunk/uClibc/libc/signal/sigset.c
trunk/uClibc/libc/stdlib/abort.c
trunk/uClibc/libc/sysdeps/linux/common/ssp.c
trunk/uClibc/libpthread/linuxthreads.old/pthread.c
trunk/uClibc/libpthread/linuxthreads.old/signals.c
trunk/uClibc/libpthread/linuxthreads/pthread.c
Changeset:
Modified: trunk/uClibc/libc/misc/syslog/syslog.c
===================================================================
--- trunk/uClibc/libc/misc/syslog/syslog.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libc/misc/syslog/syslog.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -207,10 +207,6 @@
memset(&action, 0, sizeof(action));
action.sa_handler = closelog_intern;
- /* __sigemptyset(&action.sa_mask); - memset already did it */
- /* Only two errors are possible for sigaction:
- * EFAULT (bad address of &oldaction) and EINVAL (invalid signo)
- * none of which can happen here. */
sigaction(SIGPIPE, &action, &oldaction);
saved_errno = errno;
Modified: trunk/uClibc/libc/pwd_grp/lckpwdf.c
===================================================================
--- trunk/uClibc/libc/pwd_grp/lckpwdf.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libc/pwd_grp/lckpwdf.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -111,7 +111,6 @@
memset (&new_act, '\0', sizeof (struct sigaction));
new_act.sa_handler = noop_handler;
__sigfillset (&new_act.sa_mask);
- /* new_act.sa_flags = 0; */
/* Install new action handler for alarm and save old. */
if (sigaction (SIGALRM, &new_act, &saved_act) < 0) {
Modified: trunk/uClibc/libc/signal/sigignore.c
===================================================================
--- trunk/uClibc/libc/signal/sigignore.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libc/signal/sigignore.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -31,8 +31,6 @@
struct sigaction act;
memset(&act, 0, sizeof(act));
- /*__sigemptyset (&act.sa_mask);*/
- /*act.sa_flags = 0;*/
act.sa_handler = SIG_IGN;
return sigaction (sig, &act, NULL);
Modified: trunk/uClibc/libc/signal/sigset.c
===================================================================
--- trunk/uClibc/libc/signal/sigset.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libc/signal/sigset.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -55,8 +55,6 @@
#endif /* SIG_HOLD */
memset(&act, 0, sizeof(act));
- //__sigemptyset (&act.sa_mask);
- //act.sa_flags = 0;
act.sa_handler = disp;
if (sigaction (sig, &act, &oact) < 0)
return SIG_ERR;
Modified: trunk/uClibc/libc/stdlib/abort.c
===================================================================
--- trunk/uClibc/libc/stdlib/abort.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libc/stdlib/abort.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -94,7 +94,6 @@
if (SIG_DFL) /* if it's constant zero, already done */
act.sa_handler = SIG_DFL;
__sigfillset(&act.sa_mask);
- /*act.sa_flags = 0; - memset did it */
sigaction(SIGABRT, &act, NULL);
goto abort_it;
Modified: trunk/uClibc/libc/sysdeps/linux/common/ssp.c
===================================================================
--- trunk/uClibc/libc/sysdeps/linux/common/ssp.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libc/sysdeps/linux/common/ssp.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -58,7 +58,6 @@
/* Make the default handler associated with the signal handler */
memset(&sa, 0, sizeof(sa));
__sigfillset(&sa.sa_mask); /* Block all signals */
- /* sa.sa_flags = 0; - memset did it */
if (SIG_DFL) /* if it's constant zero, it's already done */
sa.sa_handler = SIG_DFL;
sigaction(SSP_SIGTYPE, &sa, NULL);
Modified: trunk/uClibc/libpthread/linuxthreads/pthread.c
===================================================================
--- trunk/uClibc/libpthread/linuxthreads/pthread.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libpthread/linuxthreads/pthread.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -563,17 +563,13 @@
will be inherited by all other threads. */
memset(&sa, 0, sizeof(sa));
sa.sa_handler = pthread_handle_sigrestart;
- /* __sigemptyset(&sa.sa_mask); */
- /* sa.sa_flags = 0; */
__libc_sigaction(__pthread_sig_restart, &sa, NULL);
sa.sa_handler = pthread_handle_sigcancel;
sigaddset(&sa.sa_mask, __pthread_sig_restart);
- /* sa.sa_flags = 0; */
__libc_sigaction(__pthread_sig_cancel, &sa, NULL);
if (__pthread_sig_debug > 0) {
sa.sa_handler = pthread_handle_sigdebug;
__sigemptyset(&sa.sa_mask);
- /* sa.sa_flags = 0; */
__libc_sigaction(__pthread_sig_debug, &sa, NULL);
}
/* Initially, block __pthread_sig_restart. Will be unblocked on demand. */
@@ -1153,9 +1149,7 @@
implementation uses since this would be passed to the new
process. */
memset(&sa, 0, sizeof(sa));
- /*__sigemptyset(&sa.sa_mask);*/
- /*sa.sa_flags = 0;*/
- if (SIG_DFL) /* if it's constant zero, it's already done too */
+ if (SIG_DFL) /* if it's constant zero, it's already done */
sa.sa_handler = SIG_DFL;
__libc_sigaction(__pthread_sig_restart, &sa, NULL);
__libc_sigaction(__pthread_sig_cancel, &sa, NULL);
Modified: trunk/uClibc/libpthread/linuxthreads.old/pthread.c
===================================================================
--- trunk/uClibc/libpthread/linuxthreads.old/pthread.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libpthread/linuxthreads.old/pthread.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -473,17 +473,13 @@
will be inherited by all other threads. */
memset(&sa, 0, sizeof(sa));
sa.sa_handler = pthread_handle_sigrestart;
- /* __sigemptyset(&sa.sa_mask); */
- /* sa.sa_flags = 0; */
__libc_sigaction(__pthread_sig_restart, &sa, NULL);
sa.sa_handler = pthread_handle_sigcancel;
sigaddset(&sa.sa_mask, __pthread_sig_restart);
- /* sa.sa_flags = 0; */
__libc_sigaction(__pthread_sig_cancel, &sa, NULL);
if (__pthread_sig_debug > 0) {
sa.sa_handler = pthread_handle_sigdebug;
__sigemptyset(&sa.sa_mask);
- /* sa.sa_flags = 0; */
__libc_sigaction(__pthread_sig_debug, &sa, NULL);
}
/* Initially, block __pthread_sig_restart. Will be unblocked on demand. */
@@ -930,8 +926,6 @@
implementation uses since this would be passed to the new
process. */
memset(&sa, 0, sizeof(sa));
- /*__sigemptyset(&sa.sa_mask);*/
- /*sa.sa_flags = 0;*/
if (SIG_DFL) /* if it's constant zero, it's already done */
sa.sa_handler = SIG_DFL;
__libc_sigaction(__pthread_sig_restart, &sa, NULL);
Modified: trunk/uClibc/libpthread/linuxthreads.old/signals.c
===================================================================
--- trunk/uClibc/libpthread/linuxthreads.old/signals.c 2008-12-01 18:41:55 UTC (rev 24222)
+++ trunk/uClibc/libpthread/linuxthreads.old/signals.c 2008-12-01 20:29:52 UTC (rev 24223)
@@ -209,8 +209,6 @@
sighandler[s].old == (arch_sighandler_t) SIG_IGN) {
memset(&sa, 0, sizeof(sa));
sa.sa_handler = pthread_null_sighandler;
- /* __sigemptyset(&sa.sa_mask); */
- /* sa.sa_flags = 0; */
sigaction(s, &sa, NULL);
}
}
More information about the uClibc-cvs
mailing list