[uClibc 0000938]: getent: minor feature additions and code clean-up

[bugs at busybox.net]

A NOTE has been added to this issue. 
====================================================================== 
http://busybox.net/bugs/view.php?id=938 
====================================================================== 
Reported By:                zen
Assigned To:                uClibc
====================================================================== 
Project:                    uClibc
Issue ID:                   938
Category:                   New Features
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             07-08-2006 17:08 PDT
Last Modified:              07-10-2006 03:20 PDT
====================================================================== 
Summary:                    getent: minor feature additions and code clean-up
Description: 
I had occasion to look at the uClibc script "getent" and felt compelled to
clean out the cargo-cult programming style.  I believe that this version
is clearer, and I've added some minor features while I was in there:
  * usage clause, if no arguments or "--help" requested
  * original version appears to have been intending to "exit 2" on failure
to match, but didn't
  * basic, probably good enough, support for ethers and netgroups
  * faster ;-)   [as if that matters for this script]
====================================================================== 

---------------------------------------------------------------------- 
 psm - 07-10-06 02:20  
---------------------------------------------------------------------- 
Anything you do the script should behave as the getent binary from glibc
I don't really see the need for NIS related stuff 

---------------------------------------------------------------------- 
 zen - 07-10-06 03:07  
---------------------------------------------------------------------- 
1) If the script in uClibc-0.9.28 behaved like that in glibc, then this one
does too; if it didn't then this one doesn't either.  If you're asking me
to fix something that is broken, please be more clear about the request? 
An example of a feature that behaves differently (or is missing) would be
helpful as a starting point.

2) If by "NIS related stuff" you're referring to "ethers and netgroups",
that was prompted by a comment in the 0.9.28 file about "not implemented",
and my implementation was simply to add those two files to one of the case
branches (the one already handling hosts|protocols|rpc|services).  Perhaps
it'd be strange for someone to have a /etc/netgroups file and want to query
it with getent, but the code to (minimally) support it is trivial, so why
not?

 

---------------------------------------------------------------------- 
 psm - 07-10-06 03:20  
---------------------------------------------------------------------- 
I am the "author" of that file, despite the header part, I have also added
the
comment about missing features. I originally tried to make the script
behave
as glibc-2.2.5's, some changes where though later necessary to it (see svn
logs)
I haven't checked if you took the .28 or svn version as starting point,
svn is
for sure better (I haven't even compared yet what you did, I commented
only on
the comments you provided). Ethers and netgroups are not ok iirc by simply
adding
them to the existing check, I can't recall though why 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
07-08-06 17:08  zen            New Issue                                    
07-08-06 17:08  zen            Status                   new => assigned     
07-08-06 17:08  zen            Assigned To               => uClibc          
07-08-06 17:08  zen            File Added: getent                           
07-10-06 02:20  psm            Note Added: 0001505                          
07-10-06 03:06  zen            Note Added: 0001506                          
07-10-06 03:07  zen            Note Edited: 0001506                         
07-10-06 03:20  psm            Note Added: 0001507                          
======================================================================