[PATCH] fuser: small code shrink

Denys Vlasenko vda.linux at googlemail.com
Sun Jun 6 20:57:16 UTC 2010


On Thursday 03 June 2010 18:22, Maksym Kryzhanovskyy wrote:
> Attached is a patch that move body of lonely functions to the place of their calls.
> 
> function                                             old     new   delta
> fuser_main                                           911     877     -34
> ------------------------------------------------------------------------------
> (add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-34)             Total: -34 bytes

Applied, thanks!

> Also my gcc (4.4.4) writes the type punning warnings around
> #define G (* (struct globals *) & bb_common_bufsiz1).
> Is it dangerous?
> 
> gcc output:
>   CC      procps/fuser.o
> procps/fuser.c: In function 'add_pid':
> procps/fuser.c:45: warning: dereferencing type-punned pointer will break strict-aliasing rules
> procps/fuser.c: In function 'add_inode':
> procps/fuser.c:59: warning: dereferencing type-punned pointer will break strict-aliasing rules
> procps/fuser.c: In function 'search_dev_inode':
> procps/fuser.c:118: warning: dereferencing type-punned pointer will break strict-aliasing rules
> procps/fuser.c: In function 'fuser_main':
> procps/fuser.c:287: warning: dereferencing type-punned pointer will break strict-aliasing rules

Well, yeah, gcc-4.4.x spews a lot of these...
-- 
vda


More information about the busybox mailing list